Skip to content

Revert listAll behaviour for templates & iso#9309

Merged
sureshanaparti merged 1 commit intoapache:4.19from
shapeblue:revert-template-list-all
Jun 28, 2024
Merged

Revert listAll behaviour for templates & iso#9309
sureshanaparti merged 1 commit intoapache:4.19from
shapeblue:revert-template-list-all

Conversation

@vishesh92
Copy link
Copy Markdown
Member

@vishesh92 vishesh92 commented Jun 28, 2024 •
edited
Loading

Description

Reverts #9064 . Also reverts the changes done in #9300. And UI changes from this PR #9196.

adding listall=true with templatefilter=self is returning templates with account system as well.

(mycloud) __ > list templates templatefilter=self filter=name,account
(mycloud) __ > list templates templatefilter=self filter=name,account listall=true 
{
  "count": 1,
  "template": [
    {
      "account": "system",
      "name": "SystemVM Template (KVM)"
    }
  ]
}

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@sureshanaparti
Copy link
Copy Markdown
Contributor

sureshanaparti commented Jun 28, 2024

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 28, 2024

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.27%. Comparing base (46f6725) to head (be6078a).

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19   #9309       +/-   ##
============================================
- Coverage     15.01%   4.27%   -10.74%     
============================================
  Files          5393     364     -5029     
  Lines        471455   29441   -442014     
  Branches      59447    5148    -54299     
============================================
- Hits          70787    1260    -69527     
+ Misses       392781   28038   -364743     
+ Partials       7887     143     -7744
Flag Coverage Δ
uitests 4.27% <ø> (+<0.01%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vishesh92 vishesh92 force-pushed the revert-template-list-all branch from f084bdd to be6078a Compare June 28, 2024 08:24
@vishesh92 vishesh92 changed the title Revert listAll behaviour for templates Revert listAll behaviour for templates & iso Jun 28, 2024
@sureshanaparti
Copy link
Copy Markdown
Contributor

sureshanaparti commented Jun 28, 2024

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 28, 2024

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@sureshanaparti sureshanaparti added this to the 4.19.1.0 milestone Jun 28, 2024
@sureshanaparti sureshanaparti added the Severity:Critical Critical bug label Jun 28, 2024
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 28, 2024

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10186

@sureshanaparti sureshanaparti self-assigned this Jun 28, 2024
@sureshanaparti
Copy link
Copy Markdown
Contributor

sureshanaparti commented Jun 28, 2024

Verified the listing templates behavior.

(testenv)  > list templates templatefilter=self filter=name,account
(testenv)  > 
(testenv)  > list templates templatefilter=self filter=name,account listall=true 
(testenv)  >

with self template:

(testenv)  > list templates templatefilter=self filter=name,account
{
  "count": 1,
  "template": [
    {
      "account": "admin",
      "name": "CentOS7"
    }
  ]
}
(testenv)  > 
(testenv)  > list templates templatefilter=self filter=name,account listall=true 
{
  "count": 1,
  "template": [
    {
      "account": "admin",
      "name": "CentOS7"
    }
  ]
}
(testenv)  >

@sureshanaparti
Copy link
Copy Markdown
Contributor

sureshanaparti commented Jun 28, 2024

Merging this, as the change in listall behavior earlier resulting in test failures.

@sureshanaparti sureshanaparti merged commit d4446ee into apache:4.19 Jun 28, 2024
@DaanHoogland DaanHoogland deleted the revert-template-list-all branch July 1, 2024 06:53
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 2, 2024
@vishesh92 @dhslove
Revert listAll behaviour for templates (apache#9309)
eca0b93
@vishesh92 vishesh92 mentioned this pull request Jan 12, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@shwstppr shwstppr Awaiting requested review from shwstppr

@yadvr yadvr Awaiting requested review from yadvr

@harikrishna-patnala harikrishna-patnala Awaiting requested review from harikrishna-patnala

Assignees

@sureshanaparti sureshanaparti

Labels

component:UI Severity:Critical Critical bug

Projects

No open projects
Apache CloudStack 4.19.1
Status: Done

Milestone

4.19.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@vishesh92 @sureshanaparti @blueorangutan